Commit Graph
706 Commits
Author SHA1 Message Date
Olaf Bergmann b9bcdc10ff examples/server.c: added flag -g to join multicast groups
This code is taken from client.c where it makes no sense.

TODO: leave group when the server is stopped.
2015-06-10 18:08:33 +02:00
Olaf Bergmann ababd3f7f2 net.c: Removed misleading comment
The behavior of coap_send_impl() has been changed long time ago
but this comment was still there.
2015-06-10 18:06:30 +02:00
Olaf Bergmann 91f37ae1a7 coap_io.c: select outbound interface when responding to multicast requests
coap_network_send() uses the address given by local_interface as
source address of outgoing IP packets. For responses to requests
that have been received via IP multicast, this address is a
multicast group and thus must not be set as source in the IP header.

As a workaround, this change clears the address and ifindex so that
the kernel selects a suitable outbound interface.
2015-06-10 17:59:52 +02:00
Olaf Bergmann d989bb174c net.c: Suppress RST and error responses for multicast requests
When a request has been received via IP multicast, negative
responses including RST should not be sent. This modification
uses the new result code COAP_DROPPED_RESPONSE to indicate that
the response was intentionally suppressed. As the error handling
code only checks for COAP_INVALID_TID, no error messages will
be emitted due to this new behavior.
2015-06-10 17:55:36 +02:00
Olaf Bergmann e4519daf14 pdu.h: new coap_send() result code for dropped responses
The new coap_tid_t code COAP_DROPPED_RESPONSE can be used to
indicate that a response has been dropped by coap_send_impl().
2015-06-10 17:52:14 +02:00
Olaf Bergmann 3c84f5c012 net.c, pdu.h: ensure that valid transaction ids are positive
The calculation of transaction ids did not ensure that the result
is always greater or equal zero. To avoid conflicts with the error
codes returned by coap_send(), the calculation now masks out the
lower half.
2015-06-10 17:46:53 +02:00
Olaf Bergmann 83a06c7969 net.c: removed debug output from function no_response() 2015-06-10 13:07:06 +02:00
Olaf Bergmann 774fc01ec1 tests: temporarily change log-level to remove expected warnings
Some unit tests in tests/test_options.c and tests/test_pdu.c check
for error cases, causing warning messages to be emitted by the
library code. As the expected result is checked separately, the
warnings can be suppressed to avoid confusion.
2015-06-07 12:32:09 +02:00
Olaf Bergmann 24a83b7b0e updated libcoap-1.{map,sym} to include new option filter functions
With commit e4e2e57, three new functions have been added to the
public API, hence the symbol files need an update.
2015-06-07 12:30:12 +02:00
Olaf Bergmann 3e10a49c43 debug.c: added option No-Response to list of known option types
With this change, the new No-Response option is recognized by the
helper function msg_option_string() called from coap_show_pdu() for
pretty-printing CoAP messages.
2015-06-07 12:21:58 +02:00
Olaf Bergmann 8e73295b66 tests/test_options.c: Added unit tests for option filters
A new test suite 'option filter' was added to the CUnit tests to
check correctness of the new option filter implementation.
2015-06-07 12:21:58 +02:00
Olaf Bergmann e4e2e57218 option.[hc]: new option filter implementation
The implementation of option filters based on coap_opt_filter_t
has changed to improve support for long option numbers. An option
filter is now a sparse field of a fixed size that can hold up to
COAP_OPT_FILTER_LONG options with a number larger than 255, and
up to COAP_OPT_FILTER_SHORT options with a number of 255 or less.

The space taken by coap_opt_filter_t is
2 * ((((COAP_OPT_FILTER_SHORT + 1) >> 1) + COAP_OPT_FILTER_LONG) + 1),
or 12 bytes with the default settings for COAP_OPT_FILTER_SHORT == 6
and COAP_OPT_FILTER_LONG == 2.

Three new functions have been added to the option filter API:
* coap_option_filter_set() to store an option number in a filter,
* coap_option_filter_get() to check if a filter contains a given
  option number, and
* coap_option_filter_unset() to remove an option number from a
  filter.

The previously existing functions coap_option_setb(), coap_option_getb(),
and coap_option_clrb() continue to work on the new option filter
unchanged but now are deprecated.
2015-06-07 12:21:58 +02:00
Olaf Bergmann 6db8e5172d net.c: fixed calculation of mask bit for no-response option
* The shift in function no_response was off by one bit.
* The response code must be checked, not the request method.
2015-06-07 12:21:58 +02:00
Olaf Bergmann bf9a3c7a1b net.c: Implementation of No-Response option
Response suppression according to draft-tcs-coap-no-response-option-11.
2015-06-07 12:21:58 +02:00
Olaf Bergmann c5a1faad0c pdu.h: Added code for No-Response option
IANA has reserved 284 for No-Response, described in
http://www.iana.org/go/draft-tcs-coap-no-response-option

See also:
http://www.iana.org/assignments/core-parameters/core-parameters.xhtml#option-numbers

As a side-effect, COAP_MAX_OPT was set to 65535.
2015-06-07 12:21:57 +02:00
Olaf Bergmann 83c17e8f17 testdriver.c: Remove comment on known bugs
With commit eec9ad2, the two outstanding bugs in the test suite
have been fixed.
2015-06-07 12:21:57 +02:00
Olaf Bergmann 81d4297b50 option.[hc]: Fix type of option parameter
Since CoAP options can have a numeric type between 0 and 65535, the
type parameter of coap_check_option() must be at least 16 bits.
2015-06-07 12:21:57 +02:00
Olaf Bergmann 519da113a3 debug.c: improved output of zero-length option values
The function print_readable() did not add a terminating zero in case
len == 0. Now, the output buffer will always have a terminating '\0'
when buf has at least one byte free (i. e. buflen > 0). Note that the
function result does not include the trailing zero-byte.
2015-06-07 12:15:30 +02:00
Olaf Bergmann 312fc9251b debug.c: made output of coap_show_pdu() more readable
The new format[0] was inspired by the discussion[1] on the IETF CoRE
mailing list. Changes include:

* Print human-readable message type and method/response code
* Output token included in {...} even if token is empty
* Print human-readable option types
* Print human-readable option values where possible
* Print human-readable Content-Format and Block options
* Print hex string included in <<...>> for binary content,
  human-readable string included in '...' for text content
* Use '::' as payload delimiter if message contains a payload

[0] http://www.ietf.org/mail-archive/web/core/current/msg06069.html
[1] http://www.ietf.org/mail-archive/web/core/current/msg06062.html
2015-06-07 12:15:30 +02:00
Olaf Bergmann 1ea9e1c213 Renamed libcoap-1.0.{map,sym,pc.in} to libcoap-1.{map,sym,pc.in}
As commit 8380870 has simplified the API version numbering, these
filenames must be adjusted.
2015-06-07 12:11:48 +02:00
Carsten Schoenert d01e1cad2e expand i/c/coap.h to include additional information
The header coap.h should be the only header file a user has to include
to get functions from the libcoap available. Bu we have to provide not
only the header interface to the user, the user needs also some extra
information like the libcoap version or upstream related infos.

To get these automated in to a shipped coap.h header file we simple can
use some autotool magic and expand some macros while configure is
running and pasing i/c/coap.h.in. By this we can currently add the
following macro variables:

 LIBCOAP_PACKAGE_BUGREPORT -> upstream email contact
 LIBCOAP_PACKAGE_NAME      -> the used package name (libcoap)
 LIBCOAP_PACKAGE_STRING    -> package name + version
 LIBCOAP_PACKAGE_URL       -> upstream homepage
 LIBCOAP_PACKAGE_VERSION   -> the current used version

All these macros variables are expanded from the respective macro names
from the configure run. The variables are prefixed because this with
LIBCOAP_ to not get name clashing on the user side while running the
autotools of the users project.

There are probably more predefined macros needed, but they can be easily
added later into include/coap/coap.h.in.
2015-06-02 20:41:37 +02:00
Carsten Schoenert 83808704ff configure.ac: simplify the API version number
As we never want to break the API it makes no deeper sence to use a
numbered version '1.0' as this is the same as like a simple '1'.
The defined API number is used within the library so a defined version
'1.0' is also used for the namimg inside the library and other tools
reading them from the library.
Let's reduce the API version to '1' and simplify the naming for the
library by this.
2015-06-02 20:41:37 +02:00
Carsten Schoenert 21431bcb2f examples/Makefile.am: small fix for the path declaration 2015-06-02 20:41:37 +02:00
Carsten Schoenert 5f6ae26e2c doc/Doxygen.in: Do not use FreeSans as dot fontname
The FreeSans font isn't shipped by doxygen anymore so we can not asumme
that the font is available on the system of the user.
Just let doxygen pick up a usable font by itself.
2015-06-02 20:41:37 +02:00
Carsten Schoenert a78bd8c876 doc/Makefile.am: respect DESTDIR variable
The old behavior didn't allow a additonal setting of the DESTDIR
variable. This is a serious problem while building within a chroot for
example. Also the implementation of the stamp file was triggering
multiple builds in some cirumstances. This handling is reverted with the
remove of the old stamp file handling.
2015-06-02 20:41:37 +02:00
Carsten Schoenert bbe048ca8b Makefile.am: add more files to distribution
The CONTRIBUTE and TODO file should be included to the tarball as well.
2015-06-02 20:41:37 +02:00
Carsten Schoenert 35524ec1cf CONTRIBUTE: fix up wording, expanding file 2015-06-02 20:41:37 +02:00
Carsten Schoenert b8618fedb7 TODO: adding a TODO file to track needed changes 2015-06-02 20:41:37 +02:00
Olaf Bergmann 8a96bfa5c2 net.h: fixed ugly macro usage in coap_new_message_id()
context->message_id has been incremented as a side-effect of calling
the htons macro. To avoid potential issues with this, the increment
operation has been moved outside the macro call.
2015-05-23 13:58:41 +02:00
Carsten Schoenert a4c163937a i/c/subribe.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:43 +02:00
Carsten Schoenert 1d79a041ba i/c/str.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:42 +02:00
Carsten Schoenert a21adde03e i/c/resource.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:40 +02:00
Carsten Schoenert d15ecb60ec i/c/prng.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:38 +02:00
Carsten Schoenert 5d7c25c289 i/c/pdu.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:36 +02:00
Carsten Schoenert 6588dfe810 i/c/option.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:35 +02:00
Carsten Schoenert 8d22cd6544 i/c/net.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:34 +02:00
Carsten Schoenert c43a47578c i/c/mem.h: fix doxygen warnings, no functional changes
Just fixing up the warning from doxygen so the documentation will be
more usable. Also fixing up some whitespace, punctiation marking and
indentation issues.
2015-04-14 16:05:32 +02:00
Carsten Schoenert 5fca704c4e i/c/hashkey.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:31 +02:00
Carsten Schoenert 9ab6d050e6 i/c/encode.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:05:28 +02:00
Carsten Schoenert 62ddbd232c i/c/debug.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:01:34 +02:00
Carsten Schoenert 7af8edf8a9 i/c/coap_time.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:01:33 +02:00
Carsten Schoenert 54abde5943 i/c/coap_io.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues
2015-04-14 16:01:31 +02:00
Carsten Schoenert 9da72684c8 i/c/coap.h: whitespace cleanup, reformatting, no changes
Just some whitespace cleanup.
2015-04-14 16:01:29 +02:00
Carsten Schoenert 4d7752ddf0 i/c/block.h: whitespace cleanup, reformatting, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:01:17 +02:00
Carsten Schoenert e2683eb218 i/c/bits.h: whitespace cleanup, reformating, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 16:01:09 +02:00
Carsten Schoenert e256844253 i/c/async.h: whitespace cleanup, reformating, no changes
Just some cleanup like whitespace, punctuation marking and indentation
issues.
2015-04-14 15:55:24 +02:00
Carsten Schoenert ed59118841 i/c/address.h: whitespace cleanup, reformating, no changes
Just some cleanup like whitespace, punctiation marking and indentation
issues.
2015-04-14 15:54:33 +02:00
Carsten Schoenert 531c5da5da Doxyfile.in: adding some excludes for lwip related files
Due changes to the *.c and *.h files (added for the lwip support) we have
to exclude files that are not related to the library.
2015-04-14 15:53:27 +02:00
Olaf Bergmann db28c5ac0c CONTRIBUTE: fixed minor nits
Removed word duplication, "is" vs. "are", adj vs. adv
2015-04-14 12:19:40 +02:00
Carsten Schoenert d3d78902db CONTRIBUTE: adding info file for contributers
The file CONTRIBUTE is primarily for user who wants to help to improve
the libcoap project. Please expand this file with helpful informations
for anybody who is interests in helping.

Signed-off-by: Olaf Bergmann <bergmann@tzi.org>
2015-04-14 12:09:59 +02:00