In particular for TCP support.
Also added in retrying to get the lwip git 3 times for the CI tests as the
lwip host server is currently not that reliable, returning 502 gateway errors.
Makes reading the code simpler.
Context is no longer used as global_lock is used in the coap_lock_lock() and
coap_lock_unlock() functions.
Part 3 of 3.
Update coap_lock_lock() and coap_lock_unlock() macros and all users.
Makes reading the code simpler.
Context is no longer used as global_lock is used in the coap_lock_lock() and
coap_lock_unlock() functions.
Part 2 of 3.
Update coap_lock_check_locked() and all users.
Makes reading the code simpler.
Context is no longer used as global_lock is used in the coap_lock_lock() and
coap_lock_unlock() functions.
Part 1 of 3.
Update coap_lock_callback(), coap_lock_callback_ret(),
coap_lock_callback_release(), coap_lock_callback_ret_release() and
coap_lock_invert() macros and all users.
If multiple clients subscribe to the same resource, one of the clients
'goes away', the server will eventually close down the session for that client
which will then remove any subscriptions, iterating through the different
resources.
If this happens at the same time that coap_resource_notify_observers() is called
in another thread, and the GET/FETCH handler is called for a common resource
and in particular for the session that is now going away, on return from the
callback the subscription may no longer exist. This PR fixes this window.
In addition, if the resource subscriber list is being traversed, then a another
call to coap_notify_observers() for the same resource will not generate a new set
unsolicited observe responses for multi-thread protection.
Update
Malformed PDUs were responsed to with a RST. Now request PDUs with invalid
lengths are also reported with a 4.02 response.
See RFC7252 5.4.3 and 5.4.1.
Unfortunately tests/testdriver always exited with 0, even if there was a test
suite error. This meant that CI tests were not picking up any issues.
tests/testdriver now exits with a value of 1 if there is a test suite issue.
Errors corrected in/for the test suite.
The checking can be overriden by using coap_register_option().
Updated the diagnostic payload for 4.02 responses to be inline with RFC 7252,
and not include the actual errant options in the response.
Add in limited caching for multiple clients requesting an Observe subscription
for the same upstream session resource so that only a single observation request
is sent upstream and any unsolicited response is sent back to all the
requesting clients.
This requires a change in the recently added handler registered to
coap_register_proxy_response_handler(), which no longer should no longer call
coap_proxy_forward_response(), but just return a PDU for forwarding on.
When initating a multicast request, multiple unicast responses can occur.
If the unicast response subsequently generates further traffic (in other words
a BLOCK1 or BLOCK2 transfer) to complete the request/response sequence, each
unicast transfer can behave differently.
Set up different coap_lg_crcv_t for each unicast response for the session.
Set up different coap_lg_xmit_t for each unicast request if doing large transmits.
Reference initial transmitted request PDU rather than maintaining copies of the
PDU in coap_lg_crcv_t or coap_lg_xmit_t.
If calculated timeout is 0 in coap_io_prepare_io_lkd(), then do not set overall
timeout to 0 so that when passed back to caller it does not get reset to the
caller's max defined timeout.
Updated some timeout check functions to update remaining timeout in a new
parameter and to return 1 if this parameter was updated, else 0. for simplicity.
It was also unsafe to set the initial max timeout value to -1 as coap_tick_t
can be int64_t.
const coap_pdu_t * parameters are passed into application (call-back handler)
code. If the application code then calls a libcoap API with a
const coap_pdu_t * parameter, it is not possible to increment the reference
counter so that multiple entities can reference the same PDU and an entity's
call to coap_delete_pdu() does not prematurely remove the PDU until all the
entities have finished.
This code allows the (const) PDU's reference counter to be incremented.
Allow re-establishment with upstream server when server restarts.
When upstream server re-connects, re-establish any (D)TLS sessions
and active observe subscriptions.
Supported by a new function coap_context_set_session_reconnect_time().
When a server cleanly closes down (calls coap_free_context()), when
a resource gets deleted, a 4.04 message is sent out (not when using
coap_persist(3)) for any active observe subscriptions. If a server knows it is
going to be restarted, then there is no need to send out a observe failed message.
When deleting a resource when normally running, it is correct to send out a 4.04
Not Found response as the resource has genuinely gone away. However, when the
server is cleaning shutting down, it is better to use 5.03 Service Unavailable to
indicate the situation may be temporary.
Add a common cleanup function to make sure all information is correctly
freed off.
Make sure that there is client session stickability to use the same proxy entry
when making new requests.
If coap_send() returns COAP_INVALID_MID, or other internal issue found in
coap_notify_observers(), when sending an unsolicited response, do not flag
to send again as soon as possible.
Jon Shallow