obgm/libcoap
2
0 Fork 0
mirror of https://github.com/obgm/libcoap.git synced 2026-11-06 09:42:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

net.c: Fix response code for unknown resources

Browse Source 
John Carter has pointed out that non-GET requests for a resource
that does not exist caused a 4.05 response ("Method not allowed").
This fix corrects this behavior to return 4.04 in case a resource
does not exist and, for .well-known/core, 4.05 if anything but
a GET request was received.
This commit is contained in:
Olaf Bergmann committed 2016-12-14 19:56:14 +01:00
1 parent bbe8ffab7f
commit fb66920d5f
1 file changed
+12 -20
Download Patch File Download Diff File Expand all files Collapse all files
src/net.c
+12 -20
View File
@@ -1391,30 +1391,22 @@ handle_request(coap_context_t *context, coap_queue_t *node) {
* be the well-known URI. In that case, we generate a default
* response, otherwise, we return 4.04 */
switch(node->pdu->hdr->code) {
case COAP_REQUEST_GET:
if (is_wkc(key)) { /* GET request for .well-known/core */
if (is_wkc(key)) { /* request for .well-known/core */
if (node->pdu->hdr->code == COAP_REQUEST_GET) { /* GET */
info("create default response for %s\n", COAP_DEFAULT_URI_WELLKNOWN);
response = coap_wellknown_response(context, node->pdu);
} else { /* GET request for any another resource, return 4.04 */
debug("GET for unknown resource 0x%02x%02x%02x%02x, return 4.04\n",
key[0], key[1], key[2], key[3]);
response =
coap_new_error_response(node->pdu, COAP_RESPONSE_CODE(404),
opt_filter);
}
break;
default: /* any other request type */
debug("unhandled request for unknown resource 0x%02x%02x%02x%02x\r\n",
key[0], key[1], key[2], key[3]);
} else {
debug("method not allowed for .well-known/core\n");
response = coap_new_error_response(node->pdu, COAP_RESPONSE_CODE(405),
opt_filter);
}
} else { /* request for any another resource, return 4.04 */
debug("request for unknown resource 0x%02x%02x%02x%02x, return 4.04\n",
key[0], key[1], key[2], key[3]);
response =
coap_new_error_response(node->pdu, COAP_RESPONSE_CODE(404),
opt_filter);
}
if (response