obgm/libcoap
2
0 Fork 0
mirror of https://github.com/obgm/libcoap.git synced 2026-11-12 11:40:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

block.c: Fix possible null-pointer dereference

Browse Source 
Commit 9cb2f62a3 [1] has introduced library-internal handling of
Block1 and Block2 requests. To add the data to the response body the
function coap_add_data_large_internal() is used.

This change calls the function independent of a Block2 request unless
request is NULL. The response code is set to 500 if
coap_add_data_large_internal() failed.

Fixes Coverity-Id 1514379

[1] https://github.com/obgm/libcoap/commit/9cb2f62a3eef2e0aeb682615b785d4734b473bd4
This commit is contained in:
Olaf Bergmann committed 2022-02-21 14:10:16 +01:00
1 parent 0f76881802
commit b42c184f74
1 file changed
+7 -17
Download Patch File Download Diff File Expand all files Collapse all files
src/block.c
+7 -17
View File
@@ -698,25 +698,15 @@ coap_add_data_large_response(coap_resource_t *resource,
default: /* everything is good */
;
}
if (!coap_add_data_large_internal(session, response, resource, query,
maxage, etag, length, data,
release_func, app_ptr,
request->code)) {
response->code = COAP_RESPONSE_CODE(500);
goto error;
}
return 1;
}
/*
* BLOCK2 not requested
*/
if (!coap_add_data_large_internal(session, response, resource, query, maxage,
etag, length, data, release_func,
app_ptr, request->code)) {
response->code = COAP_RESPONSE_CODE(400);
/* add data body */
if (request &&
!coap_add_data_large_internal(session, response, resource, query,
maxage, etag, length, data,
release_func, app_ptr,
request->code)) {
response->code = COAP_RESPONSE_CODE(500);
goto error;
}