obgm/libcoap
2
0 Fork 0
mirror of https://github.com/obgm/libcoap.git synced 2026-11-04 17:02:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

net.c: coap_option_check_critical() not updating 'unknown' by ref

Browse Source 
'unknown' is updated by coap_option_check_critical if there is a critical
option, but as it is not passed in by reference, any caller does not see
any change to 'unknown'.

Pass in 'unknown' by reference.

Issue got missed in change e2e7830
This commit is contained in:
Jon Shallow committed 2021-05-26 14:57:48 +01:00
1 parent 2ffce0464b
commit 58fca65ceb
2 files changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

include/coap3/coap_net_internal.h
+1 -1
View File
@@ -309,7 +309,7 @@ void coap_dispatch(coap_context_t *context, coap_session_t *session,
*/
int coap_option_check_critical(coap_context_t *ctx,
coap_pdu_t *pdu,
coap_opt_filter_t unknown);
coap_opt_filter_t *unknown);
/**
* Creates a new response for given @p request with the contents of @c
src/net.c
+5 -5
View File
@@ -697,7 +697,7 @@ coap_free_context(coap_context_t *context) {
int
coap_option_check_critical(coap_context_t *ctx,
coap_pdu_t *pdu,
coap_opt_filter_t unknown) {
coap_opt_filter_t *unknown) {
coap_opt_iterator_t opt_iter;
int ok = 1;
@@ -735,7 +735,7 @@ coap_option_check_critical(coap_context_t *ctx,
/* When opt_iter.number is beyond our known option range,
* coap_option_filter_set() will return -1 and we are safe to leave
* this loop. */
if (coap_option_filter_set(&unknown, opt_iter.number) == -1) {
if (coap_option_filter_set(unknown, opt_iter.number) == -1) {
break;
}
}
@@ -3009,7 +3009,7 @@ coap_dispatch(coap_context_t *context, coap_session_t *session,
/* Flush out any entries on session->delayqueue */
coap_session_connected(session);
}
if (coap_option_check_critical(context, pdu, opt_filter) == 0)
if (coap_option_check_critical(context, pdu, &opt_filter) == 0)
goto cleanup;
/* if sent code was >= 64 the message might have been a
@@ -3087,14 +3087,14 @@ coap_dispatch(coap_context_t *context, coap_session_t *session,
/* find transaction in sendqueue in case large response */
coap_remove_from_queue(&context->sendqueue, session, pdu->mid, &sent);
/* check for unknown critical options */
if (coap_option_check_critical(context, pdu, opt_filter) == 0) {
if (coap_option_check_critical(context, pdu, &opt_filter) == 0) {
coap_send_rst(session, pdu);
goto cleanup;
}
break;
case COAP_MESSAGE_CON: /* check for unknown critical options */
if (coap_option_check_critical(context, pdu, opt_filter) == 0) {
if (coap_option_check_critical(context, pdu, &opt_filter) == 0) {
if (COAP_PDU_IS_REQUEST(pdu)) {
response =