From be107f0229f6396d0711d0b86f6b6bbae788b7b5 Mon Sep 17 00:00:00 2001 From: Jon Shallow Date: Sat, 30 May 2026 10:00:57 +0100 Subject: [PATCH] coap_proxy.c: Fix memory leak --- src/coap_proxy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/coap_proxy.c b/src/coap_proxy.c index 0e1188fa..7f830f32 100644 --- a/src/coap_proxy.c +++ b/src/coap_proxy.c @@ -1118,8 +1118,7 @@ coap_proxy_forward_request_lkd(coap_session_t *session, &uri) < 0) { /* Need to return a 5.05 RFC7252 Section 5.7.2 */ coap_log_warn("Proxy URI not decodable\n"); - coap_delete_pdu_lkd(pdu); - return 0; + goto failed; } if (!coap_uri_into_optlist(&uri, NULL, &optlist, 0)) { coap_log_err("Failed to create options for URI\n"); @@ -1149,6 +1148,7 @@ coap_proxy_forward_request_lkd(coap_session_t *session, /* Update pdu with options */ coap_add_optlist_pdu(pdu, &optlist); coap_delete_optlist(optlist); + optlist = NULL; } else { /* * Duplicate request PDU for onward transmission (with new token). @@ -1199,6 +1199,7 @@ coap_proxy_forward_request_lkd(coap_session_t *session, failed: response->code = COAP_RESPONSE_CODE(500); + coap_delete_optlist(optlist); coap_delete_pdu_lkd(pdu); return 0;