From abfe2a3c6cb0d09091ea94642953f696cb4a6509 Mon Sep 17 00:00:00 2001 From: Adrian Freihofer Date: Fri, 1 Nov 2024 13:38:10 +0100 Subject: [PATCH] CMakeLists.txt: remove vendored tinydtls build path Do not write the absolute build path into libcoapTargets.cmake. The libcoapTargets.cmake is supposed to be packaged and installed by distros. An absolute path referring to the build directory looks therefore wrong. Some build frameworks like Yocto have quality assurance check which handle these issues as a warning or as an error. Example: WARNING: libcoap-4.3.4-r0 do_package_qa: QA Issue: File /usr/lib/cmake/libcoap/libcoapTargets.cmake in package libcoap-dev contains reference to TMPDIR [buildpaths] Declaring this header files as build interface looks like the right fix. In case of a bundled tinytls library the header files should be handled like the header files from libcoap itself: Either in the build folder of libcoap or in /usr/include as declared one line above. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9d1e14f1..6e1ac775 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -829,7 +829,7 @@ target_include_directories( $ $ $ - $<$,$>:${CMAKE_BINARY_DIR}/include/tinydtls> + $,$>:${CMAKE_BINARY_DIR}/include/tinydtls>> $<$:${GNUTLS_INCLUDE_DIR}> $<$:${MBEDTLS_INCLUDE_DIRS}> $<$:${WOLFSSL_INCLUDE_DIR}>)