From 11224dde47b333709dd15be40964672c0f482a94 Mon Sep 17 00:00:00 2001 From: Jon Shallow Date: Thu, 15 Mar 2018 20:33:25 +0000 Subject: [PATCH] resource.c: Fix memory leaks when deleting observers When freeing off a subscriber entry, free off the saved query at the same time. Already done once, needs to be done in the three other instances. --- src/resource.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/resource.c b/src/resource.c index 2c93c76c..0b106bdd 100644 --- a/src/resource.c +++ b/src/resource.c @@ -629,6 +629,8 @@ coap_delete_observer(coap_resource_t *resource, coap_session_t *session, if (resource->subscribers && s) { LL_DELETE(resource->subscribers, s); coap_session_release( session ); + if (s->query) + coap_delete_string(s->query); COAP_FREE_TYPE(subscription,s); } @@ -643,6 +645,8 @@ coap_delete_observers(coap_context_t *context, coap_session_t *session) { if (s->session == session) { LL_DELETE(resource->subscribers, s); coap_session_release(session); + if (s->query) + coap_delete_string(s->query); COAP_FREE_TYPE(subscription, s); } } @@ -806,6 +810,8 @@ coap_remove_failed_observers(coap_context_t *context, coap_cancel_all_messages(context, obs->session, obs->token, obs->token_length); coap_session_release( obs->session ); + if (obs->query) + coap_delete_string(obs->query); COAP_FREE_TYPE(subscription, obs); } break; /* break loop if observer was found */